aws / sagemaker-training-toolkit

Train machine learning models within a 🐳 Docker container using 🧠 Amazon SageMaker.
Apache License 2.0
484 stars 116 forks source link

JSON fail to parse HP should be reworded #8

Closed ericangelokim closed 4 years ago

ericangelokim commented 5 years ago

We have received customer feedback that the 'Fail' info lines can be confusing. This should be reworded to something friendlier to avoid the confusion.

Relevant line here: https://github.com/aws/sagemaker-containers/blob/8ba4085548d28c8651cbd28b3049af58b3057fbc/src/sagemaker_containers/_env.py#L214

ChoiByungWook commented 5 years ago

@ericaws,

Any suggestions on the new wording? Feel free to submit a PR as well.

icywang86rui commented 5 years ago

@ericaws Any suggestions on the new wording? Also could you tell us what's confusing your customer?

jesterhazy commented 5 years ago

Closing due to lack of activity.