search

aws / secrets-store-csi-driver-provider-aws

The AWS provider for the Secrets Store CSI Driver allows you to fetch secrets from AWS Secrets Manager and AWS Systems Manager Parameter Store, and mount them into Kubernetes pods.
Apache License 2.0
459 stars 130 forks source link

Add imagePullSecrets to the Helm Chart #184

Closed g-m-o-n-e-y closed 1 year ago

g-m-o-n-e-y commented 1 year ago

Issue #, if available:

Description of changes: Added imagePullSecrets to the daemonset to use if you need a secret to authenticate with a container repository.

This change was deployed to an EKS cluster using a built tar.gz file of the chart. https://github.com/ni/secrets-store-csi-driver-provider-aws/releases/download/0.1.0/0-1-0.tar.gz

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

dhorner71 commented 1 year ago

how do i up vote this change?

jbct commented 1 year ago

Thank you for the PR. Can you create an issue and elaborate on the use case or problem this intends to solve? Please include some reproduction steps, etc. I'm going to close the PR for now until we can investigate further.

g-m-o-n-e-y commented 1 year ago

I think the issue is pretty clear (wanting to use a private docker repo), but either way apparently someone else is trying to do this as well in #200 so I'll drop my attempt