Open vikram-katkar opened 1 year ago
Patch and project coverage have no change.
Comparison is base (
8d3e503
) 53.15% compared to head (7ce584b
) 53.15%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is open for a while. Do you know @simonmarty if this can be reviewed? (not sure who will it be but saw that you contributed to one file recently so tagged you 🙂 )
Could you explain your use case? Helm chart configuration options can be overriden based on your needs. Why does this need to be merged back into the default configuration?
Yes I was able to work around this by setting the tolerations but I wasn't sure if it should be set as default? I am still new to EKS and saw this issue (https://github.com/aws/secrets-store-csi-driver-provider-aws/issues/267). If we can't set that as default, may be we can add it in troubleshooting?
I followed the docs to use csi driver provider for secrets manager and ran into this issue.
@simonmarty Most folks would probably assume the Daemon set runs on all nodes by default. If not, users might end up dealing with issues and struggle with configurations, making it a bit of a hassle to give the tool a spin.
Setting it as the default would save users from this hassle. The pros can still tweak things if they want to by using overrides.
I'm good to merge this based on the above info and the fact that the Secrets Store CSI Driver does the same thing in their helm chart
Another consideration before making this the default is that it works the other way when running some workloads on Fargate. When tolerating the Fargate nodes' taint, a DeamonSet will try to schedule pods on said nodes, which does not work. I've had to remove the default "tolerate all taints" from a number of chart defaults because of this (and it can be a PITA to work out exactly which magic incantations to use to get the correct value through Terraform and then Helm with their template languages).
@toretore Would #247 address the issue you're raising?
@simonmarty Yes, most likely.
Issue #, if available:
Description of changes: Adding default
toleration
to the daemonSet to tolerate anytaints
.Ref: https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.