aws / secrets-store-csi-driver-provider-aws

The AWS provider for the Secrets Store CSI Driver allows you to fetch secrets from AWS Secrets Manager and AWS Systems Manager Parameter Store, and mount them into Kubernetes pods.
Apache License 2.0
438 stars 123 forks source link

Allow setting `driver-writes-secrets` argument via Helm values #337

Open Elentary opened 3 months ago

Elentary commented 3 months ago

Providers binary supports specifying driver-writes-secrets bool argument to let the driver do the write instead of the plugin. However, Helm chart currently does not allow to set this flag.

I see no reason in not having a Helm-chart value for this, especially taking into account the fact that this flag is required for deploying provider in self-hosted non-EKS clusters.

I would like to open a PR implementing this feature request if you do not mind.

jbct commented 2 months ago

Hi @Elentary - thanks for the issue and corresponding PR. Do you have any details behind why you need this to be available in the helm chart?