aws / serverless-application-model

The AWS Serverless Application Model (AWS SAM) transform is a AWS CloudFormation macro that transforms SAM templates into CloudFormation templates.
https://aws.amazon.com/serverless/sam
Apache License 2.0
9.29k stars 2.37k forks source link

fix: add new partition to arn generation #3574

Closed aaythapa closed 3 months ago

aaythapa commented 3 months ago

Issue #, if available

Description of changes

Added the ${AWS::Partition} psuedo parameter in this PR so that we didn't have to maintain a static list but there is a lot of code in SAM that relies on that static list and its causing tests in the new region to fail.

We can use ${AWS::Partition} in the future but would require a bigger code change. To unblock us in the new region I'm just going to add the new region's partition into the static list for now.

Description of how you validated changes

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.