aws / serverless-application-model

The AWS Serverless Application Model (AWS SAM) transform is a AWS CloudFormation macro that transforms SAM templates into CloudFormation templates.
https://aws.amazon.com/serverless/sam
Apache License 2.0
9.29k stars 2.37k forks source link

chore: encrypt SNS and Kinesis resources in integration test templates #3578

Closed gracelu0 closed 2 months ago

gracelu0 commented 2 months ago

Issue #, if available

N/A

Description of changes

Enable encryption using KmsMasterKeyId for SNS topic and StreamEncryption for Kinesis stream resources in integration test templates to follow best security practices.

Description of how you validated changes

Ran updated integration tests successfully.

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

gracelu0 commented 2 months ago

Have you tested that these integration tests are still deployable after the change?

I ran the updated integration tests locally and they pass, so they do deploy successfully still after the change.