search

aws / serverless-application-model

The AWS Serverless Application Model (AWS SAM) transform is a AWS CloudFormation macro that transforms SAM templates into CloudFormation templates.
https://aws.amazon.com/serverless/sam
Apache License 2.0
9.29k stars 2.37k forks source link

fix: Remove ENI manual deletion #3613

Closed jfuss closed 3 weeks ago

jfuss commented 3 weeks ago

Issue #, if available

None

Description of changes

Removes the code that deletes ENI. This was added because MQ was not deleting the ENIs which is not happening.

Description of how you validated changes

make pr

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

aaythapa commented 3 weeks ago

I see from the old commit this was originally added because

Number of unused Network Interfaces can accumulate and fail future test runs when there’s no more available IP addresses in the pre-created subnets.

will we see the same errors after removing it?

jfuss commented 3 weeks ago

@aaythapa

will we see the same errors after removing it?

We shouldn't. MQ reached out because they are attempting to delete ENIs that no longer exist, and the running assumption is it is caused by this.