Closed aaythapa closed 1 week ago
Should we pin the version as 1.10.16 or < 1.10.15? If they release a new version without fixing it, we will have to change it again.
Should we pin the version as 1.10.16 or < 1.10.15? If they release a new version without fixing it, we will have to change it again.
If we pin a version now then we'd have to unpin eventually no? This way if the next version fixes it then we don't have to make another change. Imo if they release another version without fixing this issue then we can pin a version 😅
Yeah if we pin a version now we will need to unpin eventually. There will be a little additional work but it's safer to make sure we don't use the bad version in the future (we can test the version before unpinning). Not a merge blocker though.
Issue #, if available
3617
Description of changes
Pydantic versions 1.10.15 and 1.10.17 introduced breaking changes. Exclude those versions from being installed.
Description of how you validated changes
Ran
make init
withpydantic>=1.8,!=1.10.15,!=1.10.17,<2
(to insure pydantic V1 got installed).pydantic 1.10.16
was installedChecklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be added to
sam init
through aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.