search

awsdocs / amazon-aurora-user-guide

The open source version of the Amazon Aurora User Guide. You can provide feedback by submitting issues in this repo, or propose changes by submitting a pull request.
Other
53 stars 101 forks source link

Update DBActivityStreams.md #33

Closed Santiago-Freitas closed 3 years ago

Santiago-Freitas commented 4 years ago

the code previously posted on this page doesn't work with the latest version of aws_encryption_sdk. My fixes makes this code work with the latest version of aws_encryption_sdk and also with python3

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

lanceashdown66 commented 3 years ago

Hi Santiago,

Thank you for the pull request. And I apologize that our response is so late.

I discussed this PR with our developers. It looks like your comments were made about an older version of the file, which has since been updated. Most of your suggested changes have been addressed. You suggested FORBID_ENCRYPT_ALLOW_DECRYPT, but we use REQUIRE_ENCRYPT_ALLOW_DECRYPT. The developer said to leave this as-is. You suggested added parenthesis to one line: print (decrypt_decompress(payload_decoded, data_key_decrypt_result['Plaintext'])). I made this change in our source file.

The update will appear in the doc the next time we refresh.

Thanks again for your suggestions.

Best, Lance