search

awsdocs / amazon-sagemaker-developer-guide

The open source version of the Amazon SageMaker docs
Other
250 stars 262 forks source link

Fix error in placement of 'SecurityGroups' config within --default-space-settings example for VPCOnly domains. #275

Closed cgddrd-gardin closed 1 year ago

cgddrd-gardin commented 1 year ago

The existing code example leads to a validation error: 'Unknown parameter in DefaultSpaceSettings.JupyterServerAppSettings: "SecurityGroups", must be one of: DefaultResourceSpec, LifecycleConfigArns, CodeRepositories'.

As per docs here https://awscli.amazonaws.com/v2/documentation/api/latest/reference/sagemaker/update-domain.html, 'SecurityGroups' config should sit outside of 'JupyterServerAppSettings'.

Issue #, if available:

Description of changes:

Moved single '}' character to move 'SecurityGroups' config outside of 'JupyterServerAppSettings' mapping.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.