awsdocs / aws-doc-sdk-examples

Welcome to the AWS Code Examples Repository. This repo contains code examples used in the AWS documentation, AWS SDK Developer Guides, and more. For more information, see the Readme.md file below.
Apache License 2.0
9.41k stars 5.6k forks source link

[Epic] Evaluate MediaConvert examples #4574

Open brmur opened 1 year ago

brmur commented 1 year ago

Evaluate the examples for creating a job that are linked to from https://docs.aws.amazon.com/mediaconvert/latest/apireference/custom-endpoints.html

scmacdon commented 1 year ago

I looked at the code. This is V1. I recommended that they upgrade to V2 and referenced the V2 in Github.

AWSDocs-Jared commented 1 year ago

Can you help address the following notes from my internal QA team, who attempted to run the Java examples?

When I try: ./run_example.sh CreateJob 'arn:aws:iam::REDACTEDROLE:role/service-role/MediaConvert_Default_Role''s3://mediaconvert/input.ts'

I get: [ERROR] No plugin found for prefix 's3' in the current project and in the plugin groups [org.apache.maven.plugins, org.codehaus.mojo] available from the repositories [local (/Users/REDCATEDUSER/.m2/repository), central (https://repo.maven.apache.org/maven2)] -> [Help 1]

So I created a presigned url for the output https://.......... ./run_example.sh CreateJob 'arn:aws:iam::REDACTEDROLE:role/service-role/MediaConvert_Default_Role' "$pre_signed_url"

And I got this error: [ERROR] No plugin found for prefix 'https' in the current project and in the plugin groups [org.apache.maven.plugins, org.codehaus.mojo] available from the repositories [local (/Users/REDACTEDUSER/.m2/repository), central (https://repo.maven.apache.org/maven2)] -> [Help 1]

I'm not sure how I should proceed.

I was able to run ./run_example.sh ListJobs

and ./run_example.sh GetEndpointURL

One point of note is that it was unclear that I had to set endpointURL in the config.properties file (and maybe s3path?)

rlhagerm commented 1 year ago

@scmacdon, could you take a look for Jared?

scmacdon commented 1 year ago

I just executed Java V2 CreateJob and it passed the test and created the job. Output is:

MediaConvert service URL: https://mlboolfjb.mediaconvert.us-west-2.amazonaws.com MediaConvert role arn: arn:aws:iam::xxxxx8047983:role/MediaConvert_Default_Role MediaConvert input file: s3://bucketscottxxxxxx/Sample.mp4 MediaConvert output path: s3://bucketscottxxxxx/javasdk/out/ Test 1 passed

All files were in the proper S3 bucket location.

Reach out to me at scmacdon@amazon.com and i can help you more.

AWSDocs-Jared commented 1 year ago

Feedback regarding the Kotlin examples from our QA team:

Blocking Issues

Suggestions

Also, thanks in advance!

Laren-AWS commented 1 year ago

@scmacdon Can you take a look at the Kotlin feedback?