search

awsdocs / aws-doc-sdk-examples

Welcome to the AWS Code Examples Repository. This repo contains code examples used in the AWS documentation, AWS SDK Developer Guides, and more. For more information, see the Readme.md file below.
Apache License 2.0
9.6k stars 5.64k forks source link

Bash full linting (tech debt) #5940

Open rlhagerm opened 10 months ago

rlhagerm commented 10 months ago

This story is to address tech debt and failing linting after PR #5811. Complete when full linting passes.

brmur commented 10 months ago

@meyertst-aws Can you evaluate whether changes are needed to the linter for Bash, as it may be too strict at the moment.

DavidSouther commented 9 months ago

https://github.com/awsdocs/aws-doc-sdk-examples/actions/runs/7543595843/job/20534972544

Some of these are real errors:

image

So Tools Team can go in and fix those in the .tools/.github directories.

Some of these are a pattern in the aws-cli code:

image

Which I disagree with the finding, checking two things and capturing RESPONSE in that check would be onerous. So if that's a pattern @meyertst-aws approves of and uses often, let's add SC2028 to the exclusion list in https://github.com/awsdocs/aws-doc-sdk-examples/blob/main/aws-cli/bash-linux/.shellcheckrc (docs: https://www.shellcheck.net/wiki/Directive)