awsdocs / aws-doc-sdk-examples

Welcome to the AWS Code Examples Repository. This repo contains code examples used in the AWS documentation, AWS SDK Developer Guides, and more. For more information, see the Readme.md file below.
Apache License 2.0
9.62k stars 5.64k forks source link

Add advanced presigning example #7065

Open shepazon opened 1 week ago

shepazon commented 1 week ago

This changes the "upload a file" example to include a custom configuration for one of its PutObject requests. It also removes the multi-part portion of the example, which will come back shortly as a separate example, and splits the remaining upload and download examples into two separate programs, one which uploads files with or without presigning, aand one which downloads files with or without presigning.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

shepazon commented 1 week ago

I'm going to move the example to a different function than GetObject.

meyertst-aws commented 1 week ago

So wait until it is moved before I review it?

From: Eric Shepherd @.> Reply-To: awsdocs/aws-doc-sdk-examples @.> Date: Thursday, November 14, 2024 at 11:10 AM To: awsdocs/aws-doc-sdk-examples @.> Cc: "Meyer, Steve" @.>, Review requested @.***> Subject: Re: [awsdocs/aws-doc-sdk-examples] Add advanced presigning example (PR #7065)

I'm going to move the example to a different function than GetObject.

— Reply to this email directly, view it on GitHubhttps://github.com/awsdocs/aws-doc-sdk-examples/pull/7065#issuecomment-2476819566, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZ6XNGCM6EI3MK7OV5QDCDD2ATDNZAVCNFSM6AAAAABRZCYFV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZWHAYTSNJWGY. You are receiving this because your review was requested.Message ID: @.***>

shepazon commented 1 week ago

Yeah.

shepazon commented 1 week ago

Ready for review, @meyertst-aws.

shepazon commented 1 week ago

I added a call to HeadObject in the upload function to provide an example of using a custom configuration for a presigned URL in which the customized config is actually different from one the S3Client is configured to use.

shepazon commented 21 hours ago

This is now ready to review.