search

awsdocs / aws-greengrass-developer-guide

Open source version of the AWS IoT Greengrass V1 Developer Guide
Other
32 stars 31 forks source link

Remove deprecated ecr command, replace with correct version #17

Closed str3tch closed 4 years ago

str3tch commented 4 years ago

Issue #, if available:

Description of changes: Re-raising the PR, as my previous PR (https://github.com/awsdocs/aws-greengrass-developer-guide/pull/15) seemed to have been overwritten by another merge which occured at the same time.

Whilst doing this PR, I noticed the same deprecated command was being used elsewhere in the document as well, so I have edited all applicable parts of the document.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

dkdiaz commented 4 years ago

Hi @str3tch Thanks for following up on this. The get-login-password documentation says that it does take a region option when used with the Docker CLI, and it was successfully tested. We update documentation on docs.aws.amazon.com separately. It now has your suggested changes. They'll show up here the next time that this repo is updated. I'm closing this PR because the changes have been made but please feel free to reopen if you have comments/questions. Thanks again for pointing this out and helping to improve the docs!

str3tch commented 4 years ago

Hi @dkdiaz ,

I'm confused where your source of truth is then? Because I can see my changes on docs.amazon.com, as you say - but in this repo, my changes have been overwritten and reverted to the old incorrect commands. Would the next port to docs.amazon.com then bring in the incorrect commands?

cheers Stretch

dkdiaz commented 4 years ago

Hi @str3tch . Sorry for the confusion. We update this repo from docs.aws.amazon.com, which is the source of truth. I'll update this repo now to bring in the correct commands.