search

awsdocs / elastic-beanstalk-samples

This repository contains code and configuration samples (e.g. .ebextensions) for AWS Elastic Beanstalk.
Apache License 2.0
1.22k stars 889 forks source link

Should I fork the master branch or the main branch? #172

Closed amoshimei closed 4 months ago

amoshimei commented 4 months ago

I would like to add a file to this repository. However, I am uncertain about which branch to fork. Should I fork the master branch or the main branch?

The reason for my confusion is as follows: The README states, "In your fork, make your change in a branch that's based on this repo's master branch." However, the main branch appears to be the default and the most up-to-date branch.

I am a beginner in both English and contributing to OSS. Thank you for your guidance.

mrenneke-amazon commented 4 months ago

Hi @amoshimei, Please use the main branch.
I've updated the README file to refer to the main branch instead.

Thank you for your participation!

amoshimei commented 4 months ago

Hi @mrenneke-amazon, Thank you for the adjustment.

We have sent you a pull request and I will provide the detailed background below.

Recently, I received an email from AWS notifying us of the deprecation of EC2 Auto Scaling Launch Configurations in favor of Launch Templates.

"EC2 Auto Scaling Launch Configuration Deprecation Notification In 2021, AWS announced the plan to deprecate launch configurations in favor of launch templates. Since that time, continual enhancements have been made to encourage migration to launch templates. This notification contains details about the next step in the launch configuration deprecation process.

We strongly encourage the remaining customers of launch configurations to migrate to launch templates as soon as possible. Our documentation provides guidance on using the console migration tool to convert launch configurations to launch templates [1]. To identify Auto Scaling groups that are still using launch configurations, you can run this script [2]."

In response, I executed the eb create command. However, Beanstalk initiated Auto Scaling using the old Launch Configuration instead of the new Launch Template. Consequently, I had to create this configuration file.

If the Beanstalk startup process has been changed and this pull request is no longer necessary, please feel free to delete it. Additionally, if you need any further information or explanation from me, please leave a comment on this thread.