search

awsdocs / iam-user-guide

Official documentation source for the AWS Identity and Access Management (IAM) User Guide
MIT No Attribution
324 stars 355 forks source link

Make it clear that IAM does not support regex, convert: .* => * #289

Closed wparad closed 1 year ago

wparad commented 1 year ago

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

ljquin commented 1 year ago

I revised the text. Thanks for taking the time to submit a pull request.

wparad commented 1 year ago

So I don't love that you added the * back into the statement. The new update looks like this:

then allow the action only if the key value begins with "t1.*", "t2.*", or "m3.*"

But the key never begins with t1.*. It begins with t1. so saying "if it begins with t1.*" is the confusing thing that I wanted to have fixed. You explicitly added that part back.

Collectively these changes are better than the original state, but I wish that * wasn't added in there. Alternatively, changing the whole sentence would have been better to say:

then allow the action only if the key matches "t1.*", "t2.*", or "m3.*" ... something something about how t1. followed by anything.

But honestly whatever, still better than it was. Thanks for getting this in.

ljquin commented 1 year ago

Hi @wparad, I appreciate the explanation. I removed the wildcard * from the statement for added clarity.

Thanks for the feedback.