search

awslabs / amazon-app-runner-deploy

Registers an AWS AppRunner Service and deploys the application using the source code of a given GitHub repository. Supports both source code and Docker image based service
MIT No Attribution
49 stars 32 forks source link

Action to fail when deployment fail and is rolled back #11

Closed kristoffertorstad closed 1 year ago

kristoffertorstad commented 2 years ago

Description: Current behavior does not catch when deployment fail but successfully recover to previous version.

Current behavior: Action uses build from repository or ECR, updates service and waits for status !== operation_in_progress.

Suggested behavior: Action should store OperationID on updateServiceCommand() and then poll that operation until status !== operation_in_progress. Then return success on status == succeded or else fail

hariohmprasath commented 2 years ago

Hi @kristoffertorstad, Thanks for bringing this up to our attention. Do you want to submit a PR with the suggested changes? would love to take you in as a contributor.

kristoffertorstad commented 2 years ago

Hi @hariohmprasath! Thanks for the fast reply, would love to contribute! I have submitted a early draft PR. Haven't much experience with GH Actions from before, and not sure how I should go about proper testing.

hoang-van-nhat commented 2 years ago

Any update on this issue?

suzu-prog commented 2 years ago

Hi, I need this.

yyamanoi1222 commented 1 year ago

No progress on the submitted PR, so I'll start this issue.