awslabs / amazon-app-runner-deploy

Registers an AWS AppRunner Service and deploys the application using the source code of a given GitHub repository. Supports both source code and Docker image based service
MIT No Attribution
50 stars 32 forks source link

Add support for setting either a custom domain or some kind of prefix (for PR Previews) #14

Open acomito opened 2 years ago

acomito commented 2 years ago

Using this github action to deploy on a PR I can almost get PR Previews setup (like heroku, netlify, render, etc).

The only roadblock that I'm running into is I need to know the URL ahead of time-- I need a predictable URL.

If we could set the URL through the apprunner step, I have access to the PR number inside the github action so it would be easy to formulate a url to pass in pretty easily.

It seems like maybe I can create my own action/step in the mean time using the API?

https://docs.aws.amazon.com/apprunner/latest/api/API_AssociateCustomDomain.html

Otherwise, only other missing thing to match heroku etc would be shutting down a service when a PR get's closed

acomito commented 2 years ago

Just found this post which was interesting but requires using terraform: https://cdcloudlogix.com/from-heroku-review-apps-to-aws-app-runner/

hariohmprasath commented 2 years ago

Awesome, thanks for reaching out

On Mon, Apr 25, 2022 at 10:44 AM Anthony Comito @.***> wrote:

Just found this post which was helpful: https://cdcloudlogix.com/from-heroku-review-apps-to-aws-app-runner/

— Reply to this email directly, view it on GitHub https://github.com/awslabs/amazon-app-runner-deploy/issues/14#issuecomment-1108858999, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAT6QHMSOIM2YKIYYOR5ADDVG3KXJANCNFSM5UJILXTA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- With Regards, Hari Ohm Prasath

gsogol commented 2 years ago

Need custom domain as well