search

awslabs / amazon-app-runner-deploy

Registers an AWS AppRunner Service and deploys the application using the source code of a given GitHub repository. Supports both source code and Docker image based service
MIT No Attribution
49 stars 32 forks source link

Action fails when deploying App Runner Private Services deployments #24

Closed MPTG94 closed 1 year ago

MPTG94 commented 1 year ago

Hey all,

We started making use of this action to deploy an App Runner Private Service, after making use of this action many times for standard "public" app runner deployments.

The issue is that the AWS CLI/API does not report back a serviceUrl when describing an app runner private service, which causes this action to wrongfully fail (the service is deployed correctly, but the action fails because it didn't report a URL back).

I looked inside the code a bit and it seems that a PR that doesn't fail in case a serviceUrl is not returned can be easy to make, so I'd be happy to help if that solution works for everyone.

If not, please let me know if you have plans to fix this issue.

MPTG94 commented 1 year ago

I ended up opening a PR with a small fix, please let me know what you think

MPTG94 commented 1 year ago

My PR was merged with the suggested fix, closing this