search

awslabs / amazon-app-runner-deploy

Registers an AWS AppRunner Service and deploys the application using the source code of a given GitHub repository. Supports both source code and Docker image based service
MIT No Attribution
49 stars 32 forks source link

Support tags #28

Closed yyamanoi1222 closed 1 year ago

yyamanoi1222 commented 1 year ago

*Issue #21

Description of changes: Add tags input

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

DmitryGulin commented 1 year ago

Thank you very much for your PR!

I'd recommend simplifying the tag defintion format.

The current approach expects action authors to use an array of Tag compatible objects, so that the defintion would look like this:

[{ "Key": "first_tag", "The first tag value": "Tag Value" }, { "Key": "second_tag", "Value": "The second tag value" }]

The current approach is too verbose and unnecessary exposes internal dependency on AWS SDK API as a public contract. That said, I'd suggest using a simplified version to make action defintion easier for action authors to create, understand, and support:

{ "first_tag": "The first tag value", "second_tag": "The second tag value" }
yyamanoi1222 commented 1 year ago

@DmitryGulin Thank you for your feedbacks! I changed the format