awslabs / amazon-app-runner-deploy

Registers an AWS AppRunner Service and deploys the application using the source code of a given GitHub repository. Supports both source code and Docker image based service
MIT No Attribution
49 stars 32 forks source link

Validation error with cpu less than 1 or memory less than 1 #39

Closed kafji closed 1 year ago

kafji commented 1 year ago

Setting cpu or memory with value less than 1 (floating point) yield validation error.

e.g.:

cpu: 0.25
memory: 0.5

output:

2 validation errors detected: Value '0 GB' at 'instanceConfiguration.memory' failed to satisfy constraint: Member must satisfy regular expression pattern: 512|1024|2048|3072|4096|6144|8192|10240|12288|(0.5|1|2|3|4|6|8|10|12) GB; Value '0 vCPU' at 'instanceConfiguration.cpu' failed to satisfy constraint: Member must satisfy regular expression pattern: 256|512|1024|2048|4096|(0.25|0.5|1|2|4) vCPU

Probably because the input field is parsed as int. https://github.com/awslabs/amazon-app-runner-deploy/blob/f4f3010167e73cb7c67b5f1ad6eaca23fe07c115/src/action-configuration.ts#L54

austin-chen-booth commented 1 year ago

+1