search

awslabs / amazon-app-runner-deploy

Registers an AWS AppRunner Service and deploys the application using the source code of a given GitHub repository. Supports both source code and Docker image based service
MIT No Attribution
50 stars 32 forks source link

Add possibility to configure environment variables #6

Closed PatrickGotthard closed 2 years ago

PatrickGotthard commented 2 years ago

Adds support for passing environment varianbles to App Runner instances. See #4

PatrickGotthard commented 2 years ago

Currently it is not possible to update the environment variables for code-based instances. I don't know why there's no routine for updating code-based services.

hariohmprasath commented 2 years ago

Hi @PatrickGotthard, Thanks for the contribution. The code looks good to me, can you add a couple of test cases to index.test.ts?

@DmitryGulin, Can you review it once as well? Thanks

DmitryGulin commented 2 years ago

Agree with @hariohmprasath , let's have the new functionality covered with tests first.

PatrickGotthard commented 2 years ago

Hi @DmitryGulin, @hariohmprasath,

I'll add tests as soon as possible. I looked at the existing tests and it should be not that hard - even though I'm no JavaScript expert. But it would be much easier to write tests for changes like this when the config and deploy parts would be decoupled from each other - but that requires a major rewrite of the code.

Regards, Patrick

PatrickGotthard commented 2 years ago

Hi @DmitryGulin, @hariohmprasath,

in the meantime I rewrote the action from scratch because I found the code hard to read/maintain and we also had to add support for autoscaling while also not being interested in code-based deployments. Do you want to fork this pull-request or should I just close this pull-request?

Regards, Patrick

hariohmprasath commented 2 years ago

Thanks for the response @PatrickGotthard, let's close this pull request and when you get a chance you can work on making your code backward compatible and submit a new PR