search

awslabs / amazon-dynamodb-tools

Tools to make effective use of DynamoDB easier.
Apache License 2.0
113 stars 24 forks source link

Fix python requirements for numpy #11

Closed a-komarov-playrix closed 1 year ago

a-komarov-playrix commented 1 year ago

Issue #, if available: python -m pip install -r requirements.txt Pip raises error: ERROR: No matching distribution found for numpy==1.23.1

Description of changes: Fixed possible typo.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

switch180 commented 1 year ago

Hi! Thanks for your PR.

I believe the issue is that numpy 1.23.1 is only available for Python >=3.8.

Are you using Python 3.7? v1.21.3 is available for this version of Python.

I think instead of modifying the requirements, we should add a badge and/or explanation to the README explaining we require Python version 3.8 or higher (the pytest dependency requires v3.7 or higher btw).

Could you keep the requirements the same, but make changes to the README etc? It looks like shields.io is the standard for badges; we might need to make some changes to the top level folder to make these work https://github.com/badges/shields

No worries if you can't

a-komarov-playrix commented 1 year ago

You're right, I'm using python 3.7 and I overlooked recommendation to use 3.9 in readme. From this point I think nothing ought to be done. Thank you for your time!