search

awslabs / amazon-kinesis-agent

Continuously monitors a set of log files and sends new data to the Amazon Kinesis Stream and Amazon Kinesis Firehose in near-real-time.
Other
354 stars 220 forks source link

feat: Allow environment variable expansion in agent.json #135

Open frankfarrell opened 6 years ago

frankfarrell commented 6 years ago

For instance, if there is an env variable AWS_REGION, allow the following config to be valid: 

{
    "cloudwatch.emitMetrics": true,
    "kinesis.endpoint": "kinesis.${AWS_REGION}.amazonaws.com", 
    "firehose.endpoint": "firehose.${AWS_REGION}.amazonaws.com"
...etc
}
gorkemmulayim commented 5 years ago

I would like to work on this. Can you assign this to me? @chaochenq

chaochenq commented 5 years ago

That would be great, thanks @RootG, although your name doesn't show up in the assigning list, i don't know how to assign it to you.

gorkemmulayim commented 5 years ago

@chaochenq Hi, it has been a while since I have opened a pull request about this issue. I believe the pull request changes will resolve the issue. Can you please review it?