search

awslabs / amazon-kinesis-client-python

Amazon Kinesis Client Library for Python
Apache License 2.0
369 stars 223 forks source link

Make maven repository configurable via an env var #216

Open msinto93 opened 1 year ago

msinto93 commented 1 year ago

Make Maven repository configurable via an env var, default to public Maven repo

Issue number:

209

Description of changes: Currently python setup.py download_jars is hardcoded to download the KCL jars from the public Maven repository. This change makes the Maven repository configurable via an env var (defaulting to public Maven if not set). This will allow this package to be installed directly via a pip install for anyone using their own Maven repository.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

msinto93 commented 1 year ago

@shanmsac Would you mind reviewing this minor change please?

msinto93 commented 1 year ago

@akidambisrinivasan @brendan-p-lynch @furq-aws Tagging you as recent reviewers on this repo, would one of you mind taking a look at this change please?