Jars no longer downloading on install

rconroy293 commented 3 weeks ago

At least for the last several hours, it seems the jars are no longer being downloaded upon package install. This appears to be affecting the latest package version as well as older ones.

On an install from a few days ago, the jars/ subdirectory of the package includes a few dozen jars, e.g.

$ ls -la lib/python3.11/site-packages/amazon_kclpy/jars/ | head
total 27656
drwxr-xr-x. 2 code code   16384 Jun 16 18:11 .
drwxr-xr-x. 1 code code      45 Jun 19 17:06 ..
-rw-r--r--. 1 code code       0 Jun 16 18:11 __init__.py
-rw-r--r--. 1 code code  522330 Jun 16 18:11 amazon-kinesis-client-2.3.9.jar
-rw-r--r--. 1 code code  107073 Jun 16 18:11 amazon-kinesis-client-multilang-2.3.9.jar
-rw-r--r--. 1 code code    3349 Jun 16 18:11 animal-sniffer-annotations-1.20.jar
-rw-r--r--. 1 code code   12299 Jun 16 18:11 annotations-2.17.52.jar
-rw-r--r--. 1 code code   72359 Jun 16 18:11 apache-client-2.17.52.jar
-rw-r--r--. 1 code code  153649 Jun 16 18:11 auth-2.17.52.jar

A fresh install, though, results in nothing being downloaded (and no warning or error is emitted on install):

$ python3.11 -m venv tmp-venv
$ source tmp-venv/bin/activate
(tmp-venv) $ pip3 install amazon_kclpy
Collecting amazon_kclpy
  Downloading amazon_kclpy-2.1.5.tar.gz (33 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Installing backend dependencies ... done
  Preparing metadata (pyproject.toml) ... done
Collecting boto3 (from amazon_kclpy)
  Downloading boto3-1.34.130-py3-none-any.whl.metadata (6.6 kB)
Collecting argparse (from amazon_kclpy)
  Using cached argparse-1.4.0-py2.py3-none-any.whl.metadata (2.8 kB)
Collecting botocore<1.35.0,>=1.34.130 (from boto3->amazon_kclpy)
  Downloading botocore-1.34.130-py3-none-any.whl.metadata (5.7 kB)
Collecting jmespath<2.0.0,>=0.7.1 (from boto3->amazon_kclpy)
  Downloading jmespath-1.0.1-py3-none-any.whl.metadata (7.6 kB)
Collecting s3transfer<0.11.0,>=0.10.0 (from boto3->amazon_kclpy)
  Downloading s3transfer-0.10.1-py3-none-any.whl.metadata (1.7 kB)
Collecting python-dateutil<3.0.0,>=2.1 (from botocore<1.35.0,>=1.34.130->boto3->amazon_kclpy)
  Downloading python_dateutil-2.9.0.post0-py2.py3-none-any.whl.metadata (8.4 kB)
Collecting urllib3!=2.2.0,<3,>=1.25.4 (from botocore<1.35.0,>=1.34.130->boto3->amazon_kclpy)
  Downloading urllib3-2.2.2-py3-none-any.whl.metadata (6.4 kB)
Collecting six>=1.5 (from python-dateutil<3.0.0,>=2.1->botocore<1.35.0,>=1.34.130->boto3->amazon_kclpy)
  Downloading six-1.16.0-py2.py3-none-any.whl.metadata (1.8 kB)
Using cached argparse-1.4.0-py2.py3-none-any.whl (23 kB)
Downloading boto3-1.34.130-py3-none-any.whl (139 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 139.2/139.2 kB 5.4 MB/s eta 0:00:00
Downloading botocore-1.34.130-py3-none-any.whl (12.3 MB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 12.3/12.3 MB 25.5 MB/s eta 0:00:00
Downloading jmespath-1.0.1-py3-none-any.whl (20 kB)
Downloading s3transfer-0.10.1-py3-none-any.whl (82 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 82.2/82.2 kB 12.4 MB/s eta 0:00:00
Downloading python_dateutil-2.9.0.post0-py2.py3-none-any.whl (229 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 229.9/229.9 kB 18.2 MB/s eta 0:00:00
Downloading urllib3-2.2.2-py3-none-any.whl (121 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 121.4/121.4 kB 21.1 MB/s eta 0:00:00
Downloading six-1.16.0-py2.py3-none-any.whl (11 kB)
Building wheels for collected packages: amazon_kclpy
  Building wheel for amazon_kclpy (pyproject.toml) ... done
  Created wheel for amazon_kclpy: filename=amazon_kclpy-2.1.5-py3-none-any.whl size=37739 sha256=1d7aefa3020361095bee40dfd7cba0b8903943a228d3350397f34b8495b35386
  Stored in directory: /home/code/.cache/pip/wheels/bc/ff/85/01d59a44336231110aec79416c12c53fba16b2803224acb63e
Successfully built amazon_kclpy
Installing collected packages: argparse, urllib3, six, jmespath, python-dateutil, botocore, s3transfer, boto3, amazon_kclpy
Successfully installed amazon_kclpy-2.1.5 argparse-1.4.0 boto3-1.34.130 botocore-1.34.130 jmespath-1.0.1 python-dateutil-2.9.0.post0 s3transfer-0.10.1 six-1.16.0 urllib3-2.2.2
(tmp-venv) $ ls -la tmp-venv/lib/python3.11/site-packages/amazon_kclpy/jars/
total 12
drwxr-xr-x 3 code code 4096 Jun 19 21:46 ./
drwxr-xr-x 6 code code 4096 Jun 19 21:46 ../
-rw-r--r-- 1 code code    0 Jun 19 21:46 __init__.py

It doesn't seem to be an issue with Maven, as downloading the jars as part of a source install (i.e. via python setup.py download_jars) seems to run just fine.

stabl-gjn commented 1 week ago

I seem to be having the same issue. First thought it was the upgrade from 2.1.4 to 2.1.5 but that seems to be not the issue.

Instead i could reproduce it on 2.1.5:

When using python 3.11.9 it downloads the jars
When using python 3.12.4 it does not

stabl-gjn commented 1 week ago

Did some more digging, in my case this was not explicitly linked to the python version, but the pip one instead.

On v23.2.1 it seems to work while anything v24 does not seem to install the jars during the install process.

awslabs / amazon-kinesis-client-python

Jars no longer downloading on install #252