awslabs / amazon-kinesis-client

Client library for Amazon Kinesis
Apache License 2.0
635 stars 461 forks source link

move shutdownComplete call to ShardConsumer #1308

Closed vincentvilo-aws closed 3 months ago

vincentvilo-aws commented 3 months ago

Issue #, if available: N/A

Description of changes: Moving the shutdownNotification.shutdownComplete() call into the ShardConsumer.shutdownComplete method.

Having the shutdownNotification in ShutdownTask.java breaks backwards compatibility since the constructor is being modified. For future reference, any public method should use the @Builder annotation since it's better for backwards compatibility.

See PR #1302 for the original commits.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.