search

awslabs / amazon-kinesis-client

Client library for Amazon Kinesis
Apache License 2.0
632 stars 461 forks source link

Bump com.google.protobuf:protobuf-java from 3.23.4 to 4.27.0 #1344

Closed dependabot[bot] closed 1 month ago

dependabot[bot] commented 1 month ago

Bumps com.google.protobuf:protobuf-java from 3.23.4 to 4.27.0.

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
nakulj commented 1 month ago

@dependabot recreate

nakulj commented 1 month ago

This will not work for v1.x since it does not have the changes from https://github.com/awslabs/amazon-kinesis-client/pull/1340, and we will not be backporting those.

@brendan-p-lynch should I ask dependabot to ignore this dep?

brendan-p-lynch commented 1 month ago

If it is minimal work to update 1.x with the proto change I think that is fine for decreasing operational problems.

If that will take a lot of work we can either ignore or create our own PR that does work.

nakulj commented 1 month ago

Done, https://github.com/awslabs/amazon-kinesis-client/pull/1345

nakulj commented 1 month ago

@dependabot recreate

dependabot[bot] commented 1 month ago

Superseded by #1346.