bugfix: only update in memory lease if DDB lease renews without error

awslabs / amazon-kinesis-client

Client library for Amazon Kinesis

Apache License 2.0

632 stars 461 forks source link

bugfix: only update in memory lease if DDB lease renews without error #1354

Closed lucienlu-aws closed 1 week ago

lucienlu-aws commented 2 weeks ago

Issue #, if available:

Description of changes: There is a bug in DDBLeaseRenewer such that if DDB fails to update, the in memory lease would still be updated. This commit fixes this by reverting the update if the DDB update throws any error

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

lucienlu-aws commented 2 weeks ago

Backwards compatibility tests are failing due to previous PR https://github.com/awslabs/amazon-kinesis-client/pull/1340. Will double check with owners

lucienlu-aws commented 1 week ago

Double checked with owner of https://github.com/awslabs/amazon-kinesis-client/pull/1340, the failures is due to internally generated code and we should be okay.