Description of changes:
In # 1361 we skip backwards compatibility tests for proto files because they were too brittle. By using protolock through this maven plugin we can instead test the proto files directly instead of inspecting the generated Java code, which is better because:
It lets us ignore implementation specific details such as inheriting methods vs implementing them in the wrapper class directly
It lets us catch problems like reassigning field numbers or forgetting to reserve deleted field numbers, which would be missed by simply inspecting the generated code.
To verify that this works locally, I made a basic incompatible change and verified that the check failed:
Issue #, if available:
Description of changes: In # 1361 we skip backwards compatibility tests for proto files because they were too brittle. By using protolock through this maven plugin we can instead test the proto files directly instead of inspecting the generated Java code, which is better because:
To verify that this works locally, I made a basic incompatible change and verified that the check failed:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.