awslabs / amazon-kinesis-video-streams-pic

Apache License 2.0
49 stars 51 forks source link

fix potential deadlock #109

Closed hassanctech closed 3 years ago

hassanctech commented 3 years ago

Address deadlock putFrame vs callback, streams list lock should NOT be acquired inside a client/stream lock.

codecov-io commented 3 years ago

Codecov Report

Merging #109 (17e161a) into master (d580ad8) will decrease coverage by 0.07%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   87.07%   87.00%   -0.08%     
==========================================
  Files          50       50              
  Lines        9116     9124       +8     
==========================================
  Hits         7938     7938              
- Misses       1178     1186       +8     
Impacted Files Coverage Δ
src/client/src/Stream.c 83.78% <0.00%> (-0.50%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d580ad8...17e161a. Read the comment docs.