search

awslabs / amazon-kinesis-video-streams-pic

Apache License 2.0
49 stars 47 forks source link

Invalid judgement in audioVideoFrameTimestampComparator #116

Closed Nomidia closed 3 years ago

Nomidia commented 3 years ago

https://github.com/awslabs/amazon-kinesis-video-streams-pic/blob/5efcd01b75069716e1ace2a9fc00b729a2d1573f/src/client/src/FrameOrderCoordinator.c#L128

When mkvTimestamp1 and mkvTimestamp2 are equal, firstFrameFirst must be true here.

https://github.com/awslabs/amazon-kinesis-video-streams-pic/blob/5efcd01b75069716e1ace2a9fc00b729a2d1573f/src/client/src/FrameOrderCoordinator.c#L133-L134

disa6302 commented 3 years ago

Oh yes! Based on the comment, this looks like a bug. @MushMal , what do you think?

MushMal commented 3 years ago

Agree that the logic is odd. Don't know/remember why this was added like that.

Please review #118