search

awslabs / amazon-kinesis-video-streams-pic

Apache License 2.0
50 stars 47 forks source link

Added codecs enums for video and audio, removed multi-content type #130

Closed niyatim23 closed 3 years ago

niyatim23 commented 3 years ago

Issue #, if available:

Description of changes: Created audio codec id enum and video codec id enum to provide codec flexibility with Producer SDK. Removed multi-content type as it can be constructed by concatenating two base content types

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-commenter commented 3 years ago

Codecov Report

Merging #130 (8f51acf) into master (b82fd00) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   87.05%   87.05%           
=======================================
  Files          50       50           
  Lines        9119     9119           
=======================================
  Hits         7939     7939           
  Misses       1180     1180

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b82fd00...8f51acf. Read the comment docs.

hassanctech commented 3 years ago

/home/travis/build/awslabs/amazon-kinesis-video-streams-pic/src/mkvgen/tst/MkvgenApiFunctionalityTest.cpp:920:50: error: ‘MKV_H264_AAC_MULTI_CONTENT_TYPE’ was not declared in this scope EXPECT_EQ(STATUS_SUCCESS, createMkvGenerator(MKV_H264_AAC_MULTI_CONTENT_TYP

Compile errors from broken unit tests. Please adapt unit tests for this fix.

No longer needed as the #define was brought back