thinkski commented 3 years ago

Fixes #140.

Adds syslog logger to complement the existing file and stdout loggers.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-commenter commented 3 years ago

Codecov Report

Merging #141 (bfd00b2) into master (89a9996) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   87.07%   87.07%           
=======================================
  Files          50       50           
  Lines        9129     9129           
=======================================
  Hits         7949     7949           
  Misses       1180     1180

Impacted Files	Coverage Δ
src/utils/src/FileLogger.c	`90.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 89a9996...bfd00b2. Read the comment docs.

thinkski commented 3 years ago

The main issue with this solution is the fact that this is not portable on Windows. Recommend adding compile time differentiation for Windows - similar to many examples in the Utils directory. For Windows, I would recommend simply failing the compilation...?

Nice work!!!

Thanks -- made the requested changes.

thinkski commented 3 years ago

@unicornss Anything else needed to get this PR merged? I do notice CI is failing for systems that do not support syslog -- what's recommended here?

awslabs / amazon-kinesis-video-streams-pic

Adds syslog logger #141

Codecov Report