search

awslabs / amazon-kinesis-video-streams-pic

Apache License 2.0
49 stars 51 forks source link

Events mkv size bug #144

Closed jdelapla closed 3 years ago

jdelapla commented 3 years ago

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-commenter commented 3 years ago

Codecov Report

Merging #144 (4bcd6ba) into develop (31e6435) will decrease coverage by 0.06%. The diff coverage is 59.45%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #144      +/-   ##
===========================================
- Coverage    87.28%   87.21%   -0.07%     
===========================================
  Files           52       52              
  Lines         9475     9507      +32     
===========================================
+ Hits          8270     8292      +22     
- Misses        1205     1215      +10
Impacted Files Coverage Δ
src/client/src/Stream.c 83.41% <44.44%> (-0.63%) :arrow_down:
src/mkvgen/src/MkvGenerator.c 91.14% <100.00%> (+0.09%) :arrow_up:
src/utils/src/Endianness.c 70.79% <0.00%> (+2.65%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 31e6435...4bcd6ba. Read the comment docs.

kateyanurag commented 3 years ago

Change looks right to me but a few tests are failing. Can you please check @jdelapla?