search

awslabs / amazon-kinesis-video-streams-pic

Apache License 2.0
49 stars 47 forks source link

Use const PCHAR so C++ compilers won't complain about passing string constants #215

Closed daveisfera closed 11 months ago

daveisfera commented 1 year ago

C++ compilers complain about passing string constants to PCHAR so this adds const to those so the use of the value is explicit and avoids those issues

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

daveisfera commented 11 months ago

Done

disa6302 commented 11 months ago

Thanks @daveisfera . I am seeing your PR is failing clang format check. Can you clang format the code and push a new commit? You need to run this from the SDK root directory:

./scripts/check-clang.sh : This will give details on the affected files. ./scripts/clang-format.sh -f <file-name-with-path: The file name would be the one that got returned from the previous command.

daveisfera commented 11 months ago

I ran the check and none of the fixes I'm seeing are related to this PR

codecov-commenter commented 11 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (87f42b6) 75.20% compared to head (d298908) 75.18%. Report is 1 commits behind head on develop.

:exclamation: Current head d298908 differs from pull request most recent head 464b883. Consider uploading reports for the commit 464b883 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #215 +/- ## =========================================== - Coverage 75.20% 75.18% -0.02% =========================================== Files 52 52 Lines 10182 10192 +10 =========================================== + Hits 7657 7663 +6 - Misses 2525 2529 +4 ``` | [Files](https://app.codecov.io/gh/awslabs/amazon-kinesis-video-streams-pic/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [src/utils/src/Logger.c](https://app.codecov.io/gh/awslabs/amazon-kinesis-video-streams-pic/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c3JjL3V0aWxzL3NyYy9Mb2dnZXIuYw==) | `67.56% <100.00%> (ø)` | | | [src/utils/src/Threadpool.c](https://app.codecov.io/gh/awslabs/amazon-kinesis-video-streams-pic/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c3JjL3V0aWxzL3NyYy9UaHJlYWRwb29sLmM=) | `71.42% <73.07%> (-0.56%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.