awslabs / amazon-kinesis-video-streams-pic

Apache License 2.0
49 stars 51 forks source link

Utils - Remove duplicate error code #223

Closed sirknightj closed 1 year ago

sirknightj commented 1 year ago

Description of changes: Utils Library

Some error codes are duplicated. Adjust the ones starting with LOGGER_ so that they are not duplicate. https://github.com/awslabs/amazon-kinesis-video-streams-pic/blob/57637ea593f4b43c509413a44d993ed08d7f2616/src/utils/include/com/amazonaws/kinesis/video/utils/Include.h#L1292-L1293

https://github.com/awslabs/amazon-kinesis-video-streams-pic/blob/57637ea593f4b43c509413a44d993ed08d7f2616/src/utils/include/com/amazonaws/kinesis/video/utils/Include.h#L1457-L1458

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-commenter commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (3fdae37) 75.07% compared to head (b93428d) 75.11%.

:exclamation: Current head b93428d differs from pull request most recent head ee19f00. Consider uploading reports for the commit ee19f00 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #223 +/- ## =========================================== + Coverage 75.07% 75.11% +0.03% =========================================== Files 52 52 Lines 10225 10225 =========================================== + Hits 7676 7680 +4 + Misses 2549 2545 -4 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/awslabs/amazon-kinesis-video-streams-pic/pull/223/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.