Closed sirknightj closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
83334d9
) 75.12% compared to head (96dedbe
) 75.12%.:exclamation: Current head 96dedbe differs from pull request most recent head 1514252. Consider uploading reports for the commit 1514252 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issue #, if available: N/A
Description of changes:
is better than these two
Other considerations
Why don't we just use
strlen(str) > 0
?strlen
has to traverse the entire string, so it's less efficient than a comparison with the null termination character.str
is NULL, using strlen directly may result in undefined behavior.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.