awslabs / amazon-kinesis-video-streams-pic

Apache License 2.0
49 stars 47 forks source link

Add is null or empty #228

Closed sirknightj closed 9 months ago

sirknightj commented 9 months ago

Issue #, if available: N/A

Description of changes:

Other considerations

Why don't we just use strlen(str) > 0?

  1. strlen has to traverse the entire string, so it's less efficient than a comparison with the null termination character.
  2. If str is NULL, using strlen directly may result in undefined behavior.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (83334d9) 75.12% compared to head (96dedbe) 75.12%.

:exclamation: Current head 96dedbe differs from pull request most recent head 1514252. Consider uploading reports for the commit 1514252 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #228 +/- ## ======================================== Coverage 75.12% 75.12% ======================================== Files 52 52 Lines 10225 10225 ======================================== Hits 7682 7682 Misses 2543 2543 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.