codecov-commenter
commented
9 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
e611df2) 75.12% compared to head (6cfcfe5) 75.12%.:exclamation: Current head 6cfcfe5 differs from pull request most recent head aa45df9. Consider uploading reports for the commit aa45df9 to get more accurate results
Additional details and impacted files
```diff @@ Coverage Diff @@ ## develop #229 +/- ## ======================================== Coverage 75.12% 75.12% ======================================== Files 52 52 Lines 10225 10225 ======================================== Hits 7682 7682 Misses 2543 2543 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issue #, if available: N/A
Description of changes: The way the PIC layer decides whether a platform is 64 or 32 bit is by examining some pre-defined compiler macros. For 64 bad sadly we had a big miss that arm64 was entirely omitted, i.e.
__aarch64__as specified here: https://sourceforge.net/p/predef/wiki/Architectures/This is pretty bad because this maps our SIZE_T macro to a 32 bit value instead of 64 bit as the native
size_ton the platform. This PR resolves that issue.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.