awslabs / amazon-kinesis-video-streams-pic

Apache License 2.0
49 stars 51 forks source link

properly free threadpool if failed to create #231

Closed hassanctech closed 10 months ago

hassanctech commented 10 months ago

Issue #, if available:

Description of changes: If some threads were created as part of threadpoolCreate but less than minThreads then clean up will not properly happen for those threads we will not attempt to dequeue and free those tasks that were launched via THREAD_CREATE / DETACH.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1c4f6ec) 75.10% compared to head (410aeab) 75.13%.

:exclamation: Current head 410aeab differs from pull request most recent head 21a74df. Consider uploading reports for the commit 21a74df to get more accurate results

Files Patch % Lines
src/utils/src/Threadpool.c 28.57% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #231 +/- ## =========================================== + Coverage 75.10% 75.13% +0.02% =========================================== Files 52 52 Lines 10234 10230 -4 =========================================== Hits 7686 7686 + Misses 2548 2544 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.