awslabs / amazon-kinesis-video-streams-pic

Apache License 2.0
49 stars 47 forks source link

Add LOG_LEVEL_SILENT explicitly to avoid PROFILE logs from getting displayed when setting log level to SILENT #234

Closed disa6302 closed 8 months ago

disa6302 commented 8 months ago

Issue #, if available:

Description of changes:

A new log level was introduced in previous version where the value of the level is set to LOG_LEVEL_PROFILE (8). LOG_LEVEL_SILENT is set to 7. The SDK has a filtering logic where we log messages with log level greater than the set logLevel. This means, with LOG_LEVEL_SILENT, no log messages should be displayed. However, with the new added LOG_LEVEL_PROFILE, this breaks when setting log level to LOG_LEVEL_SILENT since PROFILE logs would get displayed. This PR fixes the issue.

Testing:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (af70846) 78.34% compared to head (eac5f0e) 78.34%.

:exclamation: Current head eac5f0e differs from pull request most recent head c2f8f06. Consider uploading reports for the commit c2f8f06 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #234 +/- ## ======================================== Coverage 78.34% 78.34% ======================================== Files 52 52 Lines 10065 10066 +1 ======================================== + Hits 7885 7886 +1 Misses 2180 2180 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.