awslabs / amazon-kinesis-video-streams-pic

Apache License 2.0
49 stars 47 forks source link

Remove const in the api definition for getStateMachineName #235

Closed disa6302 closed 8 months ago

disa6302 commented 8 months ago

Issue #, if available:

Description of changes:

The intent of using const was to ensure the caller of the API cannot modify the string. However, given the name is set up when invoking createStateMachineWithName, even if the caller modifies the name, the state machine name would be unaffected. If invoking createStateMachineWithName again, it would create a new state machine object.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a29912a) 78.36% compared to head (7c6b79d) 78.33%.

:exclamation: Current head 7c6b79d differs from pull request most recent head eed6a77. Consider uploading reports for the commit eed6a77 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #235 +/- ## =========================================== - Coverage 78.36% 78.33% -0.03% =========================================== Files 52 52 Lines 10066 10066 =========================================== - Hits 7888 7885 -3 - Misses 2178 2181 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.