awslabs / amazon-kinesis-video-streams-pic

Apache License 2.0
49 stars 47 forks source link

Add API for specifying thread stack size #243

Closed jdelapla closed 6 months ago

jdelapla commented 7 months ago

Issue #, if available:

What was changed? Added API to support specifying stack size of threads at time of creation. Added an ability to specify default stack sizes at compile time.

Why was it changed? Libraries that use this asset as a dependency needed to be able to customize their thread stack sizes

How was it changed? New API added, check for default compile time variable.

What testing was done for the changes? Old tests passing, new tests added. Additional changes made in upstream libraries using this change that also have tests passing.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 80.30%. Comparing base (2b835f3) to head (8c447bd). Report is 9 commits behind head on develop.

:exclamation: Current head 8c447bd differs from pull request most recent head cb8154c. Consider uploading reports for the commit cb8154c to get more accurate results

Files Patch % Lines
src/utils/src/FileIo.c 40.00% 3 Missing :warning:
src/utils/src/Thread.c 83.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #243 +/- ## =========================================== - Coverage 80.34% 80.30% -0.05% =========================================== Files 53 53 Lines 10808 10826 +18 =========================================== + Hits 8684 8694 +10 - Misses 2124 2132 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.