awslabs / amazon-kinesis-video-streams-pic

Apache License 2.0
49 stars 47 forks source link

Reset current index in case it overflows out of range #245

Closed jdelapla closed 7 months ago

jdelapla commented 7 months ago

Description of changes: In cases where the current index has passed the head value we needed a check to reset the index position. Without this check, you would need to iterate until the index had cycled around via integer overflow on a 64-bit integer.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-commenter commented 7 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2e8c2dd) 80.37% compared to head (997ef0c) 80.34%.

:exclamation: Current head 997ef0c differs from pull request most recent head 5895715. Consider uploading reports for the commit 5895715 to get more accurate results

Files Patch % Lines
src/view/src/ContentView.c 25.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #245 +/- ## =========================================== - Coverage 80.37% 80.34% -0.03% =========================================== Files 53 53 Lines 10806 10808 +2 =========================================== - Hits 8685 8684 -1 - Misses 2121 2124 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.