awslabs / amazon-kinesis-video-streams-pic

Apache License 2.0
49 stars 47 forks source link

update xcode version due to linker issue in older xcode #246

Closed hassanctech closed 6 months ago

hassanctech commented 6 months ago

Issue #, if available:

Description of changes:

See:

https://github.com/awslabs/amazon-kinesis-video-streams-pic/commit/e138caebda5788aa2490f4677327b4a8ca7f5bdb

https://github.com/awslabs/amazon-kinesis-video-streams-pic/commit/1287aaac7b3d941c78509be9c45a7944a9476904

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0c9797b) 80.34% compared to head (56bd3b3) 80.34%.

:exclamation: Current head 56bd3b3 differs from pull request most recent head 0d85034. Consider uploading reports for the commit 0d85034 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #246 +/- ## ======================================== Coverage 80.34% 80.34% ======================================== Files 53 53 Lines 10808 10808 ======================================== Hits 8684 8684 Misses 2124 2124 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sirknightj commented 6 months ago

Is there a significant difference that this plugin has over using the standard xcode-select command? https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md#xcode

sudo xcode-select -s /Applications/Xcode_15.2.app

Also, may want to adjust the readme to mention to use a specific xcode version