Closed niyatim23 closed 6 months ago
Attention: Patch coverage is 40.00000%
with 3 lines
in your changes are missing coverage. Please review.
Project coverage is 80.41%. Comparing base (
ffef12d
) to head (97c2548
). Report is 1 commits behind head on develop.:exclamation: Current head 97c2548 differs from pull request most recent head 6b63034. Consider uploading reports for the commit 6b63034 to get more accurate results
Files | Patch % | Lines |
---|---|---|
src/utils/src/FileIo.c | 40.00% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Nice! Let's add some unit test coverage here for this bug fix, one that fails before the change but succeeds now.
Awesome! In addition to unit test, are there unit tests in WebRTC we should remove from the gtest filter to test file related operations (I think the file caching tests in there are disabled at the moment for windows) ? If so, can we open a PR in webrtc referencing this commit, enabling the file cache specific tests to make sure it is all good?
Awesome! In addition to unit test, are there unit tests in WebRTC we should remove from the gtest filter to test file related operations (I think the file caching tests in there are disabled at the moment for windows) ? If so, can we open a PR in webrtc referencing this commit, enabling the file cache specific tests to make sure it is all good?
Enabled Signaling tests on Windows in: https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-c/pull/1933
Issue #, if available:
What was changed?
Why was it changed?
How was it changed?
What testing was done for the changes?
Wrote unit and functionality tests
Tested manually on Windows
Tested manually on MacOS
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.