awslabs / amazon-kinesis-video-streams-pic

Apache License 2.0

49 stars 51 forks source link

Correct missing defined in include file #257

Closed rob-baily closed 1 day ago

rob-baily commented 1 month ago

Issue #, if available: N/A

What was changed? Correct to use "defined" for preprocessor check.

Why was it changed? Receive a compiler warning with it as is. `warning: "aarch64" is not defined [-Wundef]

if defined __x86_64 || defined ppc64 || aarch64__`

How was it changed? VS Code

What testing was done for the changes? CI

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sirknightj commented 1 day ago

Hi @rob-baily, thanks for your contribution. Can you rebase your changes to the latest develop branch please? I've fixed the CI over there as part of #261 and we need to rebase to have the updated CI run for your changes.

rob-baily commented 1 day ago

Sorry for the confusion. Created #265 based off of develop and I am closing this one.