Mbedtls link

[disa6302]

Issue #, if available:

What was changed?

• Fixed the linking for LWS case to be crypto specific.

Why was it changed?

• The crypto linking is different for LWS vs CURL. In LWS case for this library, the library was always being linked to openssl, but it should link based on crypto library set up.

How was it changed?

• Linking to PRODUCER_CRYPTO_LIBRARY instead of Openssl only.

Before this change: (libmbedcrypto.so.7 => not found)

ubuntu@ip-172-31-11-82:~/amazon-kinesis-video-streams-producer-c/build$ ldd libkvsCommonLws.so
    linux-vdso.so.1 (0x00007fffcbf08000)
    libwebsockets.so.15 => /home/ubuntu/amazon-kinesis-video-streams-producer-c/open-source/lib/libwebsockets.so.15 (0x00007f32d5b7a000)
    libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f32d5800000)
    /lib64/ld-linux-x86-64.so.2 (0x00007f32d5bcf000)
    libmbedtls.so.14 => not found
    libmbedx509.so.1 => not found
    libmbedcrypto.so.7 => not found

After this change: (libmbedcrypto.so.7 => /home/ubuntu/amazon-kinesis-video-streams-producer-c/open-source/lib/libmbedcrypto.so.7 (0x00007f8518325000))

ubuntu@ip-172-31-11-82:~/amazon-kinesis-video-streams-producer-c/build$ ldd libkvsCommonLws.so
    linux-vdso.so.1 (0x00007ffdfdb56000)
    libmbedcrypto.so.7 => /home/ubuntu/amazon-kinesis-video-streams-producer-c/open-source/lib/libmbedcrypto.so.7 (0x00007f8518325000)
    libwebsockets.so.19 => /home/ubuntu/amazon-kinesis-video-streams-producer-c/open-source/lib/libwebsockets.so.19 (0x00007f85182c6000)
    libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f8518000000)
    /lib64/ld-linux-x86-64.so.2 (0x00007f85183b4000)
    libmbedtls.so.14 => not found
    libmbedx509.so.1 => not found

What testing was done for the changes?

• Added CI to only test the build

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.96%. Comparing base (13523a2) to head (80fe44e). Report is 8 commits behind head on develop.

:exclamation: Current head 80fe44e differs from pull request most recent head 2b6800a. Consider uploading reports for the commit 2b6800a to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #442 +/- ## =========================================== - Coverage 63.97% 63.96% -0.02% =========================================== Files 32 32 Lines 5083 5076 -7 =========================================== - Hits 3252 3247 -5 + Misses 1831 1829 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[hassanctech]

Nice! Is it possible to print the results of ldd from before / after to confirm we're not linking to openssl any more, i.e. it's not specified anywhere in the NEEDED section of the ELF header?

[disa6302]

Nice! Is it possible to print the results of ldd from before / after to confirm we're not linking to openssl any more, i.e. it's not specified anywhere in the NEEDED section of the ELF header?

Done!

[hassanctech]

Nice! Is it possible to print the results of ldd from before / after to confirm we're not linking to openssl any more, i.e. it's not specified anywhere in the NEEDED section of the ELF header?

Done!

Looking at the results it would say not found just because it can't find it in LD_LIBRARY_PATH or standard library path but in this case it looks like previously that library was just not built and put in the lib folder which is where it looks for it in the AFTER case. However what I was expecting to see in the BEFORE case is libssl/libcrypto in the list, since it is not there that would means previously it wasn't linking to openssl.