search

awslabs / amazon-kinesis-video-streams-producer-sdk-cpp

Amazon Kinesis Video Streams Producer SDK for C++ is for developers to install and customize for their connected camera and other devices to securely stream video, audio, and time-encoded data to Kinesis Video Streams.
Apache License 2.0
379 stars 334 forks source link

Fix Windows CI #1149

Closed stefankiesz closed 8 months ago

stefankiesz commented 8 months ago

The issue was related to path length being too long for Windows. Specifying to use long paths using the following does not fix the issue:

  1. reg add "HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FileSystem" /v LongPathsEnabled /t REG_DWORD /d 1 /f
  2. New-ItemProperty -Path "HKLM:\SYSTEM\CurrentControlSet\Control\FileSystem" ` -Name "LongPathsEnabled" -Value 1 -PropertyType DWORD -Force
  3. git config --system core.longpaths true

Similar to our Windows CI test in WebRTC SDK, the cloned repository is now moved to a shorter path.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 16.48%. Comparing base (c0b9d52) to head (6590155).

:exclamation: Current head 6590155 differs from pull request most recent head 4273108. Consider uploading reports for the commit 4273108 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1149 +/- ## ======================================== Coverage 16.48% 16.48% ======================================== Files 50 50 Lines 7018 7018 ======================================== Hits 1157 1157 Misses 5861 5861 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sirknightj commented 8 months ago

If (3) git config --system core.longpaths true didn't fix the issue, can we remove it from the CI?

sirknightj commented 8 months ago

Can we can simply configure the checkout action to clone the repository to a certain path?

      - name: Checkout Repository
        uses: actions/checkout@v3
        with:
          path: 'C:\repo'
niyatim23 commented 8 months ago

If (3) git config --system core.longpaths true didn't fix the issue, can we remove it from the CI?

That's needed in the build later I think