awslabs / amazon-kinesis-video-streams-producer-sdk-cpp

Amazon Kinesis Video Streams Producer SDK for C++ is for developers to install and customize for their connected camera and other devices to securely stream video, audio, and time-encoded data to Kinesis Video Streams.
Apache License 2.0
373 stars 334 forks source link

[BUG] There is not HEAP_DEBUB nor LOG_STREAMING in CMakeList.txt #627

Closed rodrigo-merino closed 3 years ago

rodrigo-merino commented 3 years ago

Logging Add relevent SDK logging. IMPORTANT NOTE: Please make sure to NOT share AWS access credentials under any circumstance! Please make sure they are not in the logs.

Describe the bug

Can you please fix the documentation? Following this link: https://github.com/awslabs/amazon-kinesis-video-streams-producer-sdk-cpp/blob/master/docs/linux.md#enabling-verbose-logs

There is neither HEAP_DEBUG nor LOG_STREAMING in CMakeList.txt file. I haven't found them in my installation. They can't be found neither in here https://github.com/awslabs/amazon-kinesis-video-streams-producer-sdk-cpp/blob/master/CMakeLists.txt nor anywhere else in this repo https://github.com/awslabs/amazon-kinesis-video-streams-producer-sdk-cpp/search?q=HEAP_DEBUG

Please fix the documentation to be able to enable debug logs in the producer SDK.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

SDK version number Include the SDK version you are running. If it is a specific commit on master branch, include that

Open source building If it is a build issue, include 3rd party library version and steps to how you are building it

Screenshots If applicable, add screenshots to help explain your problem.

Platform (please complete the following information):

Additional context Add any other context about the problem here.

disa6302 commented 3 years ago

@rodrigo-merino ,

Looks like you are right. We will look into this ASAP